Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credstash AttributeError error after upgrading to 1.16.2 #273

Closed
geoffbp opened this issue Feb 17, 2020 · 3 comments
Closed

Credstash AttributeError error after upgrading to 1.16.2 #273

geoffbp opened this issue Feb 17, 2020 · 3 comments
Milestone

Comments

@geoffbp
Copy link

geoffbp commented Feb 17, 2020

06:32:54 Traceback (most recent call last):
06:32:54 File "/home/jenkins-slave/workspace/Build/AMI/application-container-host-ami@17/viator-packer-venv/bin/credstash", line 5, in
06:32:54 from credstash import main
06:32:54 File "/home/jenkins-slave/workspace/Build/AMI/application-container-host-ami@17/viator-packer-venv/bin/credstash.py", line 83, in
06:32:54 setup_logging(logging.WARNING, 'credstash.log')
06:32:54 File "/home/jenkins-slave/workspace/Build/AMI/application-container-host-ami@17/viator-packer-venv/bin/credstash.py", line 73, in setup_logging
06:32:54 if logger.hasHandlers():
06:32:54 AttributeError: 'Logger' object has no attribute 'hasHandlers'

@vrgurus
Copy link
Contributor

vrgurus commented Feb 18, 2020

@geoffbp, I think is all related to same change made for logger. See #271

@eisjcormier
Copy link
Contributor

what is the plan for fixing this or reverting the logging changes?

mike-luminal added a commit that referenced this issue Mar 19, 2020
Resolves #271 #273: Remove explicit logger
@mike-luminal mike-luminal added this to the 1.17.0 milestone Mar 19, 2020
@mike-luminal
Copy link
Contributor

Resolved by #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants