Add creds3 CLI for credstash to enable S3 credential storage #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 2, 2017 09:29
and add cred3 to commit
list all key versions rather than only the latest ones
Add creds3 CLI for S3 credential store
|
Hm, seems like the Travis Python 3.2 build failure is not my fault, but some incompatibilities in the dependent package |
|
@alex-luminal please let me know if there are any issues with this PR, would really love to have the S3 credential store option to become a part of the main code |
|
@romanrev Apologies for taking so long to get back to you. I'm going through these PRs and preparing the next release. I'm planning to use some of this but I'll incorporate it as part of a refactor. Thank you for the PR. Stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
I cloned your excellent tool Credstash and modified the code to use S3 instead of DynamoDB as a separate repo (see creds3) as I did not have enough time to work on a PR to the existing code and I needed the package out ASAP.
I don't like duplicating code, however so here's the PR to merge all the changes to make sure they live there where they belong and also to obsolete the
creds3package once this version is released.Thank you!