Resolves #73: Adds binary secret support #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2017 23:37
This is perhaps a superficial approach to supporting binary secrets. If it's not satisfactory, I'd love to discuss what would be, so I can help get that on the road. I shamelessly ripped the binary check function from jfs of SO: https://stackoverflow.com/a/7392391/830495. I didn't want to introduce any external dependencies to add this support, but maybe there's a better option? I'm unsure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps a superficial approach to supporting binary secrets. If
it's not satisfactory, I'd love to discuss what would be, so I can help
get that on the road. I shamelessly ripped the binary check function
from jfs of SO: https://stackoverflow.com/a/7392391/830495.
I didn't want to introduce any external dependencies to add this
support, but maybe there's a better option? I'm unsure.