-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return context with secret material with getSecretAndContext #258
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, but can you rename this to getSecretAndMetadata
to reduce the chance of confusion with the KMS Encryption Context?
@mike-luminal ah, good point. The PR is updated with the new naming. |
Hmm, it looks like this would change the default output of |
Yup, sorry!
|
Thanks for the PR! And sorry for the delay on this after you made the requested changes. This all looks good to me. Could you please resolve the merge conflicts and I'll get this merged in? |
34136db
to
7c2f4c3
Compare
7c2f4c3
to
bfa727a
Compare
@jason-fugue thanks for the review!
again, just to test, as well as rerunning the unit tests. |
When getting a secret, it's sometimes helpful to retrieve extra context associated with it.
Note: I'm not tied to the shape of the return value.