Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

[RM-6181] Resolve incompatibility with plans from Terraform v1.0.8 #223

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

jason-fugue
Copy link
Contributor

Recent versions of Terraform have changed the format of references in plan files. An example of that change is included in the test files in this PR. Previously, references just contained the ID of the referenced resource:

...
"kms_key_id": {
    "references": [
        "aws_kms_key.cloudwatch"
    ]
}
...

Now, they contain the ID as well as the specific property being referenced:

...
"kms_key_id": {
    "references": [
        "aws_kms_key.cloudwatch.key_id",
        "aws_kms_key.cloudwatch"
    ]
}
...

This PR accounts for that change by filtering out the specific properties and just retaining the resource ID.

This will hopefully resolve #220 and #221. It could also potentially resolve #222.

Copy link
Member

@jaspervdj-luminal jaspervdj-luminal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jason-fugue jason-fugue merged commit 1945798 into master Oct 15, 2021
@jason-fugue jason-fugue deleted the fix/RM-6181/tf-1-0-8-fix branch October 15, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FG_R00377 and FG_R00041 conflict with each other FG_R00054 not working
2 participants