Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ICMP extensions in reports #806

Closed
Tracked by #33
fujiapple852 opened this issue Nov 21, 2023 · 0 comments · Fixed by #817
Closed
Tracked by #33

Add support for ICMP extensions in reports #806

fujiapple852 opened this issue Nov 21, 2023 · 0 comments · Fixed by #817
Labels
breaking A breaking change enhancement New feature or request icmp report
Milestone
0.9.0

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Nov 21, 2023 •
edited
Loading

Show ICMP extensions in json and stream reports. No support for "flat" reports csv, pretty or md. Not applicable to silent, flows or dot.

Json:

{
  "ttl": 11,
  "hosts": [
    {
      "ip": "129.250.2.50",
      "hostname": "ae-10.r32.tokyjp05.jp.bb.gin.ntt.net"
    }
  ],
  "extensions": [
    {
      "mpls": {
        "members": [
          {
            "label": 48268,
            "exp": 0,
            "bos": 1,
            "ttl": 1
          }
        ]
      }
    }
  ],
  "loss_pct": "0.00",
  "sent": 1,
  "last": "62.67",
  "recv": 1,
  "avg": "62.67",
  "best": "62.67",
  "worst": "62.67",
  "stddev": "0.00"
}

Stream:

ttl=11 addrs=129.250.2.50 exts=mpls(labels=48268) loss_pct=0.0 sent=1 recv=1 last=62.8 best=62.8 worst=62.8 avg=62.8 stddev=0.0
@fujiapple852 fujiapple852 mentioned this issue Nov 21, 2023
Open
11 tasks
@fujiapple852 fujiapple852 added report icmp enhancement New feature or request labels Nov 21, 2023
@fujiapple852 fujiapple852 self-assigned this Nov 21, 2023
fujiapple852 added a commit that referenced this issue Nov 22, 2023
@fujiapple852
feat(report): add ICMP extension data to reports (#806) - WIP
11c8ad6
@fujiapple852 fujiapple852 mentioned this issue Nov 22, 2023
Closed
fujiapple852 added a commit that referenced this issue Nov 24, 2023
@fujiapple852
feat(report): add ICMP extension data to reports (#806) - WIP
6cc3dbf
fujiapple852 added a commit that referenced this issue Nov 24, 2023
@fujiapple852
feat(report): reworked stream to display ICMP extensions (#806)
9a8b9b5
@fujiapple852 fujiapple852 mentioned this issue Nov 24, 2023
Merged
fujiapple852 added a commit that referenced this issue Nov 24, 2023
@fujiapple852
feat(report): reworked stream to display ICMP extensions (#806)
77d2646
@fujiapple852 fujiapple852 added the breaking A breaking change label Nov 24, 2023
fujiapple852 added a commit that referenced this issue Nov 24, 2023
@fujiapple852
feat(report): reworked stream to display ICMP extensions (#806)
7fcd58b
@fujiapple852 fujiapple852 removed their assignment Nov 24, 2023
@fujiapple852 fujiapple852 added this to the 0.9.0 milestone Nov 24, 2023
@chenrui333 chenrui333 mentioned this issue Nov 30, 2023
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Dec 1, 2023
@0323pin
net/trippy: update to 0.9.0
71ffae6 
[0.9.0] - 2023-11-30

Added

- Added support for tracing flows
  ([#776](fujiapple852/trippy#776))
- Added support for `icmp` extensions
  ([#33](fujiapple852/trippy#33))
- Added support for `MPLS` label stack class `icmp` extension
  objects ([#753](fujiapple852/trippy#753))
- Added support for [paris]
  (https://github.com/libparistraceroute/libparistraceroute) ECMP routing
  for `IPv6/udp` ([#749](fujiapple852/trippy#749))
- Added `--unprivileged` (`-u`) flag to allow tracing without elevated
  privileges (macOS
  only) ([#101](fujiapple852/trippy#101))
- Added `--tui-privacy-max-ttl` flag to hide host and IP details for low ttl
  hops ([#766](fujiapple852/trippy#766))
- Added `toggle-privacy` (default: `p`) key binding to show or hide private
  hops ([#823](fujiapple852/trippy#823))
- Added `toggle-flows` (default: `f`) key binding to show or hide tracing
  flows ([#777](fujiapple852/trippy#777))
- Added `--dns-resolve-all` (`-y`) flag to allow tracing to all IPs resolved
  from DNS lookup
  entry ([#743](fujiapple852/trippy#743))
- Added `dot` report mode (`-m dot`) to output hop graph in Graphviz `DOT`
  format ([#582](fujiapple852/trippy#582))
- Added `flows` report mode (`-m flows`) to output a list of all unique tracing
  flows ([#770](fujiapple852/trippy#770))
- Added `--icmp-extensions` (`-e`) flag for parsing `IPv4`/`IPv6` `icmp`
  extensions ([#751](fujiapple852/trippy#751))
- Added `--tui-icmp-extension-mode` flag to control how `icmp` extensions are
  rendered ([#752](fujiapple852/trippy#752))
- Added `--print-config-template` flag to output a template config
  file ([#792](fujiapple852/trippy#792))
- Added `--icmp` flag as a shortcut for `--protocol icmp`
  ([#649](fujiapple852/trippy#649))
- Added `toggle-help-alt` (default: `?`) key binding to show or hide
  help ([#694](fujiapple852/trippy#694))
- Added panic handing to Tui
  ([#784](fujiapple852/trippy#784))
- Added official Windows `scoop` package
  ([#462](fujiapple852/trippy#462))
- Added official Windows `winget` package
  ([#460](fujiapple852/trippy#460))
- Release `musl` Debian `deb` binary asset
  ([#568](fujiapple852/trippy#568))
- Release `armv7` Linux binary assets
  ([#712](fujiapple852/trippy#712))
- Release `aarch64-apple-darwin` (aka macOS Apple Silicon) binary
  assets ([#801](fujiapple852/trippy#801))
- Added additional Rust Tier 1 and Tier 2 binary assets
  ([#811](fujiapple852/trippy#811))

Changed

- [BREAKING CHANGE] `icmp` extension object data added to `json` and `stream`
  reports ([#806](fujiapple852/trippy#806))
- [BREAKING CHANGE] IPs field added to `csv` and all tabular
  reports ([#597](fujiapple852/trippy#597))
- [BREAKING CHANGE] Command line flags `--dns-lookup-as-info` and
  `--tui-preserve-screen` no longer require a boolean
  argument ([#708](fujiapple852/trippy#708))
- [BREAKING CHANGE] Default key binding for `ToggleFreeze` changed from `f`
  to `ctrl+f` ([#785](fujiapple852/trippy#785))
- Always render AS lines in hop details mode
  ([#825](fujiapple852/trippy#825))
- Expose DNS resolver module as part of `trippy` library
  ([#754](fujiapple852/trippy#754))
- Replaced unmaintained `tui-rs` crate with `ratatui` crate
  ([#569](fujiapple852/trippy#569))

Fixed

- Reverse DNS lookup not working in reports
  ([#509](fujiapple852/trippy#509))
- Crash on NetBSD during window resizing
  ([#276](fujiapple852/trippy#276))
- Protocol mismatch causes tracer panic
  ([#745](fujiapple852/trippy#745))
- Incorrect row height in Tui hop detail navigation view for hops with no
  responses ([#765](fujiapple852/trippy#765))
- Unnecessary socket creation in certain tracing modes
  ([#647](fujiapple852/trippy#647))
- Incorrect byte order in `IPv4` packet length calculation
  ([#686](fujiapple852/trippy#686))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking A breaking change enhancement New feature or request icmp report
Projects
None yet
Milestone
0.9.0
1 participant
@fujiapple852