Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve table column layout constraint logic #925

Closed
fujiapple852 opened this issue Jan 15, 2024 · 0 comments · Fixed by #924
Closed

Improve table column layout constraint logic #925

fujiapple852 opened this issue Jan 15, 2024 · 0 comments · Fixed by #924
Labels
enhancement New feature or request tui
Milestone
0.10.0

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Jan 15, 2024 •
edited
Loading

Each column is designated as either Fixed(n) or Variable and then to compute the width of each column we use the size n for Fixed columns and compute the size of the Variable columns as total table width - sum(fixed size columns) divided by number number of variable size columns.

The effect is that all columns remain fixed in size except the Host column which is Variable and can therefore grows or shrinks as the window is resized or columns are added or removed.

This may be replaced in future by a more complex layout algorithm but works well enough for today.
@fujiapple852 fujiapple852 added enhancement New feature or request tui labels Jan 15, 2024
@fujiapple852 fujiapple852 self-assigned this Jan 15, 2024
fujiapple852 added a commit that referenced this issue Jan 15, 2024
@fujiapple852
feat(tui): improve column width layout logic (#925)
8f8b10c
@fujiapple852 fujiapple852 mentioned this issue Jan 15, 2024
Merged
fujiapple852 added a commit that referenced this issue Jan 15, 2024
@fujiapple852
feat(tui): improve column width layout logic (#925)
55641c6
trkelly23 added a commit to trkelly23/trippy that referenced this issue Jan 15, 2024
@trkelly23
feat display jitter
d026669 
Merge in of fujiapple852#925 improvement on column display.

feat display jitter

feat display jitter(WIP)

Includes possible test approach using JSON to mimic trace data

feat(tui): improve column width layout logic (WIP)
@fujiapple852 fujiapple852 removed their assignment Jan 21, 2024
@fujiapple852 fujiapple852 added this to the 0.10.0 milestone Jan 21, 2024
@chenrui333 chenrui333 mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tui
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

feat(tui): improve column width layout logic fujiapple852/trippy
1 participant
@fujiapple852