Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracer panic for ICMP TimeExceeded packets with code 1 ("Fragment reassembly time exceeded") #979

Closed
fujiapple852 opened this issue Feb 3, 2024 · 0 comments · Fixed by #980
Closed

Tracer panic for ICMP TimeExceeded packets with code 1 ("Fragment reassembly time exceeded") #979

fujiapple852 opened this issue Feb 3, 2024 · 0 comments · Fixed by #980
Labels
bug Something isn't working
Milestone
0.10.0

Comments

@fujiapple852
Copy link
Owner

Tracer crashes when processing an IMCP TimeExceeded with a code of 1 ("Fragment reassembly time exceeded")

For sufficiently long packets, the tracer will incorrectly interpret the TE payload (the fragmented packet) as an ICMP extension and crash with a message similar to:

thread 'tracer-31398' panicked at src/tracing/packet/icmp_extension.rs:426:33:
range end index 713 out of range for slice of length 416

The fix is to filter out ICMP TimeExceeded packets where the code != 0 ("TTL expired in transit.")
@fujiapple852 fujiapple852 added the bug Something isn't working label Feb 3, 2024
@fujiapple852 fujiapple852 added this to the 0.10.0 milestone Feb 3, 2024
@fujiapple852 fujiapple852 self-assigned this Feb 3, 2024
fujiapple852 added a commit that referenced this issue Feb 3, 2024
@fujiapple852
fix(net): tracer panic for ICMP TimeExceeded packets with code 1 (#979)
c653f76
@fujiapple852 fujiapple852 mentioned this issue Feb 3, 2024
Merged
fujiapple852 added a commit that referenced this issue Feb 3, 2024
@fujiapple852
fix(net): tracer panic for ICMP TimeExceeded packets with code 1 (#979)
5093cfa
fujiapple852 added a commit that referenced this issue Feb 4, 2024
@fujiapple852
fix(net): tracer panic for ICMP TimeExceeded packets with code 1 (#979)
b98dd10
fujiapple852 added a commit that referenced this issue Feb 4, 2024
@fujiapple852
fix(net): tracer panic for ICMP TimeExceeded packets with code 1 (#979)
4accbff
fujiapple852 added a commit that referenced this issue Feb 4, 2024
@fujiapple852
fix(net): tracer panic for ICMP TimeExceeded packets with code 1 (#979)
e446047
@fujiapple852 fujiapple852 removed their assignment Feb 4, 2024
@chenrui333 chenrui333 mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

fix(net): tracer panic for ICMP TimeExceeded packets with code 1 (#979) fujiapple852/trippy
1 participant
@fujiapple852