Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icmp argument to allow shortcut for base protocol #788

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

trkelly23
Copy link
Collaborator

@trkelly23 trkelly23 commented Nov 13, 2023

The following tests for the mentioned use case:

  1. Change protocol in the config file to non default tcp or udp.
  2. Run trippy with shortcut --icmp
    Results:
    Config: protocol=icmp(v4, unprivileged) as-info=n/a details=off max-hosts=auto

This passed the basic use case please post comments if others should be run

Closes #649

src/config/cmd.rs Outdated Show resolved Hide resolved
@fujiapple852
Copy link
Owner

fujiapple852 commented Nov 13, 2023

Thanks @trkelly23 - LGTM aside from small points above and the formatting (just run a default cargo fmt to fix that). Once fixed if you can squash to a single commit (ideally feat: add icmp command shortcut (#649 ) we should be good to merge this.

@trkelly23
Copy link
Collaborator Author

PR is squashed and the changes are ready to merge.

@fujiapple852
Copy link
Owner

fujiapple852 commented Nov 13, 2023

Thanks, could you change the commit message as well? It’s a bit unclear as-is. My suggestion would be:

feat: add icmp command shortcut (#649)

@trkelly23
Copy link
Collaborator Author

Oops I missed the commit message which is all set and ready to merge.

@fujiapple852 fujiapple852 merged commit fd5ffdd into fujiapple852:master Nov 13, 2023
9 checks passed
@fujiapple852
Copy link
Owner

Merged, thanks @trkelly23 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --icmp command line shortcut
2 participants