treat symlink as file when adding to zip / #402 #422
Merged
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the `addToZip` function in `archive.go` to treat symlinks as files. If a file is a symlink, the function reads the symlink target and retrieves the file information for the target. This ensures that the correct file information is used when adding the file to the zip archive. Refactor the code to handle symlinks and update the `path` variable accordingly before creating the zip file header. This change improves the behavior of the `addToZip` function when dealing with symlinks, ensuring that the correct file information is used for symlinks in the zip archive.
add tests for symlink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for resolving a symlink target with the
--srcoption.