Emit a socket closed event in a non-async socket loop #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally when using an async web server, websocket-driver handles broken connections by attempting to write to a stream, and if that fails, it closes the socket and emits the close event. In the case of a non-async webserver like Hunchentoot, a loop form checks the stream's status manually, and then closes the socket once the loop exits. But in this case, it doesn't emit the close event. This PR adds the event to this case as well.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally when using an async web server, websocket-driver handles broken connections by attempting to write to a stream, and if that fails, it closes the socket and emits the close event. In the case of a non-async webserver like Hunchentoot, a loop form checks the stream's status manually, and then closes the socket once the loop exits. But in that case, it doesn't emit the close event. This PR adds emitting the
:closeevent after the loop terminates.