Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update deps #141

wants to merge 1 commit into from

Conversation

fulls1z3
Copy link
Owner

@fulls1z3 fulls1z3 commented Jul 8, 2021

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: N/A

** What is the new behavior?

** Does this PR introduce a breaking change?

[x] Yes
[ ] No

** Other information

@ghost
Copy link

ghost commented Jul 8, 2021

Sider has detected 1 warning on analyzing the commit 4ea43c6.

If the errors persist even after retrying, the following actions may resolve them:

If you still have problems, feel free to ask us via chat. 💬


You can turn off such notifications if unnecessary.

@m7mdbadawy
Copy link

I think I understand what the problem here maybe

So in tsconfig.json paths is used to reference core package so that it could be used by other packages ng-packagr don't use that at all that is what causes a build problem

If you just build core on its own (after updating its version in package.json) and moved it into node_modules you will be able to build other packages

If you tried to import core directly without paths you hit another problem which is the rootDir is not setup correctly you can work around this by ng-packagr/ng-packagr#1264 (comment)

This seems will require some restructuring from the same github issue linked above there is this library that did that restructure https://github.com/ngx-grpc/ngx-grpc

What do you think ?

@fulls1z3
Copy link
Owner Author

@m7mdbadawy i followed the instructions but nothing worked.

here is the output i'm getting when building http-loader from https://github.com/fulls1z3/ngx-config (same as in this repo) since it depends on the core package.these paths are clearly pointed in tools/build/tsconfig.package.json into the bundles in dist, but still not getting any luck.

➜  fulls1z3-ngx-config git:(update_deps) yarn build:http-loader
yarn run v1.22.10
$ ng-packagr -p packages/@ngx-config/http-loader/package.json -c tools/build/tsconfig.package.json
Building Angular Package

------------------------------------------------------------------------------
Building entry point '@ngx-config/http-loader'
------------------------------------------------------------------------------
Compiling TypeScript sources through ngc
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
ERROR: packages/@ngx-config/http-loader/src/config.http-loader.ts:3:30 - error TS2307: Cannot find module '@ngx-config/core' or its corresponding type declarations.

3 import { ConfigLoader } from '@ngx-config/core';
                               ~~~~~~~~~~~~~~~~~~

error Command failed with exit code 111.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

i see angular team changed the way paths are resolved from tsconfig, and not any of my efforts are helping out. i'm thinking of archiving this project since i can't go further, not any help from community and not enough time to invest to tackle this particular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants