-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support RN 74 on iOS #90
Conversation
Wiz Scan Summary
|
Adding @martin-fs since this is iOS related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy to review with "hide whitespace" option.
Looks like the getInternalInstanceHandleFromPublicInstance thingy was made "public" here.
Slightly worrying that the function that necessitated exposing it it is documented with Remove this once Paper is no longer supported and DOM Node API are enabled by default in RN.
Updated in a later PR to say: TODO(T174762768): Remove this once OSS versions of renderers will be synced.
So we can be pretty sure it will disappear at some point, but maybe at that time another entry point will be provided. Maybe access _internalInstanceHandle
directly somehow.
Does this break other react-native versions? I'm using |
Could you provide more information on the error you're seeing? @bhandanyan-nomad |
Android
Related line of code:
iOS
|
React
18.3.0
moved thecurrentProps
object into thecanonical
property. PR here.This is causing us to not be able to read our FS attributes off of the component instance.
RN
0.74.0
has a new function (PR here) calledgetInternalInstanceHandleFromPublicInstance
that will help us get at thecurrentProps
property. IfgetInternalInstanceHandleFromPublicInstance
exists, we'll try to use it as it's indicative of the new Fabric Component Tree.