Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few tweaks to enable table customization and styles for paragraphs #39

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

dcharles525
Copy link
Contributor

Hello! Below are list of changes made:

  1. Added the ability to customize table width from the AddTable func
  2. Added the ability to customize the border colors from the AddTable func
  3. Added a function under the Paragraph struct to accept style names
  4. Added tables tests modifications to make the tests run

Let me know what I can do to get this merged.

Thank you!

Copy link
Owner

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

apitable.go Outdated Show resolved Hide resolved
apitable.go Show resolved Hide resolved
apitable.go Outdated Show resolved Hide resolved
apitable.go Show resolved Hide resolved
structtable.go Outdated Show resolved Hide resolved
apitable.go Outdated Show resolved Hide resolved
Copy link
Owner

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fumiama fumiama enabled auto-merge (squash) September 24, 2024 15:13
@dcharles525
Copy link
Contributor Author

Thanks!

Absolutely! Thank you for bearing with me, I am new to Go :)

@fumiama fumiama merged commit 7782d22 into fumiama:master Sep 24, 2024
1 check failed
@fumiama
Copy link
Owner

fumiama commented Sep 24, 2024

Thanks!

Absolutely! Thank you for bearing with me, I am new to Go :)

It doesn't matter. Everyone start from new and you learn it really fast 👍. I noticed that there're some ident mismatches in your code. Maybe you should use the formatter gofmt that go standard suggesting. Generally, VSCode will suggest you to install it and format the code automatically when you press ctrl+s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants