Refactor hard-coded event types into enums

funidata · Aug 8, 2023 · ed5d0c2 · ed5d0c2
1 parent aa222fb
commit ed5d0c2
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/app-nest/src/bolt/enums/bolt-actions.enum.ts b/app-nest/src/bolt/enums/bolt-actions.enum.ts
@@ -0,0 +1,5 @@
+enum BoltActions {
+  SYNC_USERS = "sync_users",
+}
+
+export default BoltActions;
diff --git a/app-nest/src/bolt/enums/bolt-events.enum.ts b/app-nest/src/bolt/enums/bolt-events.enum.ts
@@ -0,0 +1,6 @@
+enum BoltEvents {
+  APP_HOME_OPENED = "app_home_opened",
+  USER_PROFILE_CHANGED = "user_profile_changed",
+}
+
+export default BoltEvents;
diff --git a/app-nest/src/dev-tools/dev-tools.controller.ts b/app-nest/src/dev-tools/dev-tools.controller.ts
@@ -1,12 +1,13 @@
 import { Controller } from "@nestjs/common";
 import BoltAction from "../bolt/decorators/bolt-action.decorator";
+import BoltActions from "../bolt/enums/bolt-actions.enum";
 import { UserSyncService } from "../sync/user-sync.service";
 
 @Controller()
 export class DevToolsController {
   constructor(private userSyncService: UserSyncService) {}
 
-  @BoltAction("sync_users")
+  @BoltAction(BoltActions.SYNC_USERS)
   async syncUsers({ ack }) {
     await ack();
     await this.userSyncService.syncUsers();

diff --git a/app-nest/src/gui/tabs/home-tab.controller.ts b/app-nest/src/gui/tabs/home-tab.controller.ts
@@ -1,13 +1,14 @@
 import { Controller } from "@nestjs/common";
 import BoltEvent from "../../bolt/decorators/bolt-event.decorator";
+import BoltEvents from "../../bolt/enums/bolt-events.enum";
 import { UserService } from "../../entities/user/user.service";
 import devTools from "../dev/dev-tools";
 
 @Controller()
 export class HomeTabController {
   constructor(private userService: UserService) {}
 
-  @BoltEvent("app_home_opened")
+  @BoltEvent(BoltEvents.APP_HOME_OPENED)
   async getView({ event, client, logger }) {
     const users = await this.userService.findAll();
     const { slackId } = users[0];

diff --git a/app-nest/src/sync/sync.controller.ts b/app-nest/src/sync/sync.controller.ts
@@ -1,12 +1,13 @@
 import { Controller } from "@nestjs/common";
 import BoltEvent from "../bolt/decorators/bolt-event.decorator";
+import BoltEvents from "../bolt/enums/bolt-events.enum";
 import { UserSyncService } from "./user-sync.service";
 
 @Controller()
 export class SyncController {
   constructor(private userSyncService: UserSyncService) {}
 
-  @BoltEvent("user_profile_changed")
+  @BoltEvent(BoltEvents.USER_PROFILE_CHANGED)
   async userProfileChanged({ event }) {
     await this.userSyncService.syncUsers(event.user);
   }