Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 2/multiple premises #76

Merged
merged 57 commits into from
Jul 24, 2023
Merged

Conversation

VoxBorealis
Copy link
Contributor

@VoxBorealis VoxBorealis commented Jul 11, 2023

Resolves #2
Resolves #74
Resolves #73

List of changes in this PR

DB:

  • Create table for Offices
  • Add defaultOffice (reference to Office) column to People table
  • Add a reference to Offices in Signups and Defaultsignups
  • Add a 'emoji' column to Offices?
  • Add an office reference to Jobs

Front:

  • Add an input modal for creating offices
  • Add an input modal for modifying offices (update & delete)
  • Add a view for when the app has zero offices added
  • Add dropdown menu for office selection to app home tab or to the 'oletusasetukset' modal (rename to 'asetukset'?)
  • Only show list of registrations for the selected office
  • If a user has registered to another office for a particular day, communicate that to the in some way. (different colored buttons)
  • Same thing with default signup modal

Backend:

  • Modify all registration and default registration service getters to include an office parameter. (perhaps an optional parameter? If no arg, then return all registrations)
  • Check all calls to the above mentioned functions to see if adding an office parameter is necessary.
  • Add all necessary getters & setters for offices

Misc:

  • Make necessary changes to scheduledMessage & laterRegistration
  • REMOVED Update slash commands (/listaa, /ilmoita, /poista) to support multiple premises?
  • Update docstring where necessary
  • Remove unnecessary console.logs (even those unrelated to this issue, such as the cache logs)
  • Remove outdated workaround related to Fix handling of disconnects in socket mode #73

@VoxBorealis VoxBorealis force-pushed the feature/issue-2/multiple-premises branch from c65b5a5 to fc56641 Compare July 19, 2023 11:54
@VoxBorealis VoxBorealis marked this pull request as ready for review July 19, 2023 12:07
@joonashak joonashak self-assigned this Jul 19, 2023
@joonashak joonashak modified the milestone: Spring Cleaning Jul 19, 2023
@joonashak joonashak added the feature New feature or functionality. label Jul 19, 2023
@VoxBorealis VoxBorealis force-pushed the feature/issue-2/multiple-premises branch from 1df9b0c to 1a5455b Compare July 21, 2023 10:37
@joonashak joonashak added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit fd91438 Jul 24, 2023
3 checks passed
@joonashak joonashak deleted the feature/issue-2/multiple-premises branch July 24, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor / reorganize UI code Fix handling of disconnects in socket mode Support multiple premises
2 participants