Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adblock not obtaining source from url #156

Closed
spirillen opened this issue Dec 25, 2020 · 3 comments
Closed

adblock not obtaining source from url #156

spirillen opened this issue Dec 25, 2020 · 3 comments

Comments

@spirillen
Copy link
Contributor

Bug description

See title

https://travis-ci.com/github/dns-test/PyFunceble-Sandboxed/builds/210574987 +
https://travis-ci.com/github/dns-test/PyFunceble-Sandboxed/builds/210575157

Modifications under .PyFunceble.yaml

A clear representation of what you changed.

Reproduction

Steps to reproduce the behavior:

- pyfunceble --ci --syntax -ex -w $(nproc --ignore=2)
          --adblock https://raw.githubusercontent.com/easylist/easylist/master/easyprivacy/easyprivacy_trackingservers.txt
          --adblock https://raw.githubusercontent.com/easylist/easylist/master/easylist_cookie/easylist_cookie_general_hide.txt
          --adblock https://raw.githubusercontent.com/easylist/easylist/master/fanboy-addon/fanboy_annoyance_specific_block.txt
        - tree --prune -f "${TRAVIS_BUILD_DIR}/.pyfunceble/"

Expected behavior

adblock can fetch directly from url-source as -f

Screenshots

Additional context

Add any other context about the problem here.
#155 (comment)

@spirillen spirillen mentioned this issue Dec 25, 2020
2 tasks
@spirillen
Copy link
Contributor Author

Closing as I learned --adblock is a argument like --wildcard not a "source" like -f or -uf

@keczuppp
Copy link

I don't want to interrupt the conversation in the another thread so I'm commenting here in a less important and closed thread, so I won't interrupt anything:

spirillen : https://github.com/funilrys/PyFunceble/issues/155#issuecomment-751265589:
Ping (...) @Fanboynz (...) @ THEtomaso (...)

  • did I just spot some typos in your comment as it should be:
    @ryanbr instead of @Fanboynz and @THEtomaso instead of @ THEtomaso
    or it was intentional to not ping these two directly

@spirillen
Copy link
Contributor Author

I don't want to interrupt the conversation in the another thread so I'm commenting here in a less important and closed thread, so I won't interrupt anything:

spirillen : https://github.com/funilrys/PyFunceble/issues/155#issuecomment-751265589:
Ping (...) @Fanboynz (...) @ THEtomaso (...)

* did I just spot some typos in your comment as it should be:
  `@ryanbr` instead of  `@Fanboynz` and `@THEtomaso` instead of `@ THEtomaso`
  or it was intentional to not ping these two directly

That will be lazy 😒 as I couldn't remember there exact nicks, I copied them from a commit list 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants