-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha test of --adblock #155
Comments
Ping @smed79 @ryanbr @Khrin @DandelionSprout @THEtomaso @Yuki2718 Please comment what you'll find of errors or suggestions for tests 😃 And Thank you so much for your good work with the EasyList project UPDATE: |
First report The Reported at: #156 https://travis-ci.com/github/dns-test/PyFunceble-Sandboxed/builds/210574987 |
I have been using this option combined with |
What file are you using? is it a public one I can test with? PS: the |
Have you tried https://stackoverflow.com/a/52617143/5308363 ? I had a simular problem with the GitHub Actions under Windows and I solved it by adding the Line 8 in d976127
|
My experiences with I often run into Output (Very long):
Comparatively, doing the same with EasyList Lithunia, which admittedly targets the ABP syntax instead of the uBO syntax, does not seem to cause this type of errors at all. |
So run |
Haven't got that on any of uAssets, AG, or personal lists. |
@DandelionSprout what is your test string? Exmaple of what I mean: pyfunceble --share-logs -dbr 6 -ex --dns 192.168.1.104:53 -w 6 -a --database-type mariadb --no-files --local -f somefile |
My test result is: SLOW, but my eyes haven't court any weird @Yuki2718 could you retest this issue with @funilrys suggestion? Another thing I noticed, we aren't filtering what is to become doubles...
|
Test of @DandelionSprout #155 (comment) pyfunceble --adblock --dns 192.168.1.104 192.168.1.103 192.168.1.102 192.168.1.101 \
127.0.0.1 192.158.1.2 192.158.1.3 192.158.1.4 192.158.1.5 \
-f https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianList.txt \
https://raw.githubusercontent.com/EasyList-Lithuania/easylist_lithuania/master/easylistlithuania.txt Result: No errors |
@spirillen Sure, I just forgotten. As I said, I believe the issue is specific to Japanese locale. |
Doesn't help, I still get the same error. |
Do you have a firewall configured? I'm asking because it is one of the ways to get |
Seems like this works without any noticeable problems as of 4.0.0b1.dev. I'm not 100% sure how at the time of writing, but it does. |
Hey @Yuki2718 Is this one still an issue #155 (comment) If so, I think I would suggest to put it into it's own issue, as I don't see why you shouldn't be allowed to run a full sized scan as well... |
@spirillen I will test in a few days, please wait. |
Thank you @Yuki2718! Can you test with |
On 4.0.0b19 the issue is solved, and it's noticeably faster than the old version. Thx for keeping good work! |
BTW I had to downgrade Python to 3.8 as dnspython is not yet compatible to 3.9. |
?? I'm running dnspython on python 3.9.1 without any issues python3.9 -m pip list | grep dnspython
dnspython 2.0.0
dnspython in /usr/local/lib/python3.9/dist-packages (2.0.0) And a HUGE thanks for your feedbacks @Yuki2718 |
Until now there have been non test of the
--adblock
variable....This should be the thread for that purpose.
I'll be using a valid list for this purpose from EasyList, more specific I'll be using the following list to get as broad a number of rules as possible and yet keeping things small.
If you find any test case, you think I have forgotten please post a comment.
NOTE
I'll update this particular post with any news rather than comments, to better maintain a overview of what is done and have to be done.
@funilrys Please add to this post to https://github.com/funilrys/PyFunceble/projects/6
The text was updated successfully, but these errors were encountered: