fix: error passing class with public readonly field to UI.FIeld()

fuqunaga · Jan 26, 2023 · 6b4b3fe · 6b4b3fe
1 parent 8ec6e22
commit 6b4b3fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Packages/RosettaUI/Runtime/Utilities/PropertyOrFieldGetterSetter.cs b/Packages/RosettaUI/Runtime/Utilities/PropertyOrFieldGetterSetter.cs
@@ -77,7 +77,7 @@ static Func<TParent, TValue, TParent> CreateSetter(string propertyOrFieldName)
             }
             catch (Exception e)
             {
-                Debug.Log(e);
+                Debug.LogError($"{typeof(PropertyOrFieldGetterSetter<TParent, TValue>)}.{nameof(CreateSetter)} propertyOrFieldName[{propertyOrFieldName}]\n{e}");
             }
 
             return Expression.Lambda<Func<TParent, TValue, TParent>>(block, objParam, setterValueParam).Compile();

diff --git a/Packages/RosettaUI/Runtime/Utilities/TypeUtility.cs b/Packages/RosettaUI/Runtime/Utilities/TypeUtility.cs
@@ -212,8 +212,11 @@ public ReflectionCache(Type type, IReadOnlyCollection<FieldInfo> fis, IEnumerabl
 
 
                 uiTargetPropertyOrFieldsNameTypeDic = fis
-                    .Where(fi => (fi.IsPublic && fi.GetCustomAttribute<NonSerializedAttribute>() == null)
-                                 || fi.GetCustomAttribute<SerializeField>() != null)
+                    .Where(fi => !fi.IsInitOnly)
+                    .Where(fi =>
+                        (fi.IsPublic && fi.GetCustomAttribute<NonSerializedAttribute>() == null)
+                        || fi.GetCustomAttribute<SerializeField>() != null
+                    )
                     .ToDictionary(fi => fi.Name, fi => fi.FieldType);
             }