Moved the event dispatch after setting the value. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gabe-lucas does this solve the issue with event handlers? We want to use this library for a website of us, but we're using on change and on keypress handlers which don't seem to be triggered. |
|
@vinceve This solves about half your issue. Calling the change event will work correctly with this PR however, I don't believe that key handler events will work. I can look into this a little later today when I get some time. |
|
Hi @gabe-lucas Your solution solves the problem partially. So, I fixed (v1.4.0) this issue properly and closed this PR. Thank you for your time. FYI: @vinceve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.