Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support arm/v7 and arm64 and migrate to GitHub Container Registry #102

Merged
merged 13 commits into from
Dec 7, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Dec 5, 2022

This PR adds support for linux/arm/v7 and linux/arm64 architectures, releasing container images for multiple architectures using docker manifest. Additionally, we are migrating from Docker Hub to GitHub Container Registry! 🎉


Changes

  1. Follows the tutorial from GoReleaser on how to build multi-arch Docker releases: https://carlosbecker.com/posts/multi-platform-docker-images-goreleaser-gh-actions/
  2. Revamp nightly release workflows and avoid using GoReleaser's snapshot feature.
  3. Rewrite some ./hack scripts to use getopts.
  4. Migrate from Docker Hub to GitHub Container Registry. Images can be pulled from here instead: https://github.com/orgs/furiko-io/packages

@irvinlim irvinlim force-pushed the irvinlim/feat/goreleaser-arm64 branch from e2d0ed7 to 2e6d7db Compare December 5, 2022 17:53
@irvinlim irvinlim force-pushed the irvinlim/feat/goreleaser-arm64 branch from 2e6d7db to 0c6e175 Compare December 5, 2022 17:53
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 63.50% // Head: 63.53% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6a432e6) compared to base (5ad6ccc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   63.50%   63.53%   +0.03%     
==========================================
  Files         205      205              
  Lines       10958    10957       -1     
==========================================
+ Hits         6959     6962       +3     
+ Misses       3621     3619       -2     
+ Partials      378      376       -2     
Impacted Files Coverage Δ
pkg/utils/heap/heap.go 100.00% <0.00%> (+1.07%) ⬆️
pkg/execution/util/schedule/schedule.go 77.32% <0.00%> (+1.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irvinlim
Copy link
Member Author

irvinlim commented Dec 5, 2022

Currently on hold because this conflicts with the snapshot action.

@irvinlim irvinlim force-pushed the irvinlim/feat/goreleaser-arm64 branch 2 times, most recently from e2face6 to 7ea9a34 Compare December 6, 2022 19:02
@irvinlim irvinlim force-pushed the irvinlim/feat/goreleaser-arm64 branch 2 times, most recently from deb5dd8 to be4e1de Compare December 6, 2022 20:55
@irvinlim irvinlim changed the title chore: Support docker manifests to release for arm64 chore: Support docker manifests to release for arm64, revamp nightly release workflows Dec 7, 2022
@irvinlim irvinlim changed the title chore: Support docker manifests to release for arm64, revamp nightly release workflows chore: Support docker manifests to release for arm64, revamp nightly release workflows, use ghcr.io Dec 7, 2022
@irvinlim irvinlim changed the title chore: Support docker manifests to release for arm64, revamp nightly release workflows, use ghcr.io chore: Support arm/v7 and arm64, revamp nightly release workflows, use ghcr.io Dec 7, 2022
@irvinlim irvinlim changed the title chore: Support arm/v7 and arm64, revamp nightly release workflows, use ghcr.io chore: Support arm/v7 and arm64 and migrate to GitHub Container Registry Dec 7, 2022
@irvinlim irvinlim force-pushed the irvinlim/feat/goreleaser-arm64 branch from 6ae7096 to 6a432e6 Compare December 7, 2022 05:04
@irvinlim irvinlim merged commit 42d5d20 into main Dec 7, 2022
@irvinlim irvinlim deleted the irvinlim/feat/goreleaser-arm64 branch December 7, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant