Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): Add Indexes to ParallelStatus, update GetJobCommand #90

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Jun 5, 2022

  • Update ParallelStatus to contain list of Indexes.
  • Update furiko get job command:
    • Support --output detail and show all tasks and parallel task groups.
    • Show parallel task summary based on index counts.
    • Show job status task summary based on task counts.
  • Other changes:
    • Fix incorrect enum value for TaskTerminating.
    • Deprecate TaskPendingTimeout result, TaskKilled will be used instead, and PendingTimeout will be stored in the Reason.
    • Add more GetPhase unit tests.

@irvinlim irvinlim added area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/workloads Related to workload execution (e.g. jobs, tasks) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features. area/furiko-cli Related to the command-line interface (CLI) utility. labels Jun 5, 2022
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #90 (c4f761f) into main (0954bd6) will increase coverage by 0.04%.
The diff coverage is 75.71%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   63.13%   63.17%   +0.04%     
==========================================
  Files         202      203       +1     
  Lines       10456    10722     +266     
==========================================
+ Hits         6601     6774     +173     
- Misses       3498     3581      +83     
- Partials      357      367      +10     
Impacted Files Coverage Δ
apis/execution/v1alpha1/job_types.go 100.00% <ø> (ø)
pkg/cli/printer/output.go 50.00% <ø> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 59.05% <32.43%> (-1.36%) ⬇️
pkg/runtime/testing/command.go 75.29% <40.00%> (-2.21%) ⬇️
pkg/cli/formatter/formatter.go 44.44% <44.44%> (ø)
pkg/cli/cmd/cmd_get_job.go 75.08% <75.00%> (-4.11%) ⬇️
pkg/execution/util/parallel/status.go 90.44% <91.17%> (-3.37%) ⬇️
.../execution/controllers/jobcontroller/reconciler.go 71.82% <100.00%> (ø)
pkg/execution/util/job/condition.go 95.62% <100.00%> (+0.09%) ⬆️
pkg/execution/util/job/phase.go 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0954bd6...c4f761f. Read the comment docs.

@irvinlim irvinlim merged commit a110df6 into main Jun 5, 2022
@irvinlim irvinlim deleted the irvinlim/feat/parallel-status-indexes branch June 5, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to public APIs, including CRD design, configuration, etc area/furiko-cli Related to the command-line interface (CLI) utility. area/workloads Related to workload execution (e.g. jobs, tasks) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant