CondVar::SignalAll was broken, leading to deadlocks on Windows builds.

http://code.google.com/p/leveldb/issues/detail?id=149
furszy · Aug 17, 2013 · 8487468 · 8487468
1 parent f6d84d1
commit 8487468
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/port/port_win.cc b/port/port_win.cc
@@ -109,12 +109,10 @@ void CondVar::Signal() {
 
 void CondVar::SignalAll() {
   wait_mtx_.Lock();
-  for(long i = 0; i < waiting_; ++i) {
-    ::ReleaseSemaphore(sem1_, 1, NULL);
-    while(waiting_ > 0) {
-      --waiting_;
-      ::WaitForSingleObject(sem2_, INFINITE);
-    }
+  ::ReleaseSemaphore(sem1_, waiting_, NULL);
+  while(waiting_ > 0) {
+    --waiting_;
+    ::WaitForSingleObject(sem2_, INFINITE);
   }
   wait_mtx_.Unlock();
 }