Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share - Android Updates #1253

Merged
merged 2 commits into from
Mar 10, 2019
Merged

Share - Android Updates #1253

merged 2 commits into from
Mar 10, 2019

Conversation

AndrewEQ
Copy link
Contributor

@AndrewEQ AndrewEQ commented Feb 1, 2019 •
edited
Loading

Updated to new android file permission requirements when sharing.
You will need to override the android_share_paths.xml(via AndroidShareImpl.uno) if you would like to add custom paths of folders you would like to give share access to.

https://medium.com/@andrewq/hello-world-eaa996c594b7

This PR contains:

  • Changelog
  • Documentation
  • Tests

@AndrewEQ
Share - Android Updates
d5381ff 
Updated to new android file permission requirements when sharing.
You will need to override the android_share_paths.xml(via AndroidShareImpl.uno) if you would like to add custom paths of folders you would like to give share access to.
@AndrewEQ
Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

#255
#1156

kusma
kusma previously requested changes Feb 1, 2019
View reviewed changes
Source/Fuse.Share/ShareModule.uno Outdated
@@ -144,8 +144,8 @@ namespace Fuse.Share
{
var description = args.Length>2 ? "" + args[2] : "";
if defined(android)
{
AndroidShareImpl.ShareFile("file://" + path, type, description);
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt you meant to add this tab...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, my bad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the fix into the right commit :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you mean; what is the "right commit", please explain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid introducing a mistake in one commit and then fixing it in a later. Instead, you should rebase your branch so this white-space isn't inserted in the first place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my gosh, sigh, okay...

Copy link
Contributor Author

@AndrewEQ AndrewEQ Feb 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go, if I rebase to my original commit, I think this PR will close automatically.

@kusma
Copy link
Contributor

kusma commented Feb 1, 2019 

ERROR: /com: Access to the path "/com" is denied.
ERROR: /com/fuse: Access to the path "/com" is denied.
ERROR: /com/fuse/fileprovider: Access to the path "/com" is denied.

:/

@AndrewEQ
Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

It can't create or copy the java file?

@AndrewEQ
Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

I just tried an uno clean, uno doctor and rebuild with an android export with my test app and can't reproduce that error.

@AndrewEQ
Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

Ok, figured it out, its sorted.

@kusma kusma dismissed their stale review February 18, 2019 10:18

this was resolved

@AndrewEQ AndrewEQ requested a review from kusma February 25, 2019 17:58
@ckarmy
Copy link
Contributor

ckarmy commented Feb 25, 2019

I test it and solve the crash when I try to share a image!

@AndrewEQ
Share - Android Updates - Added description to subject for email
5e67815 
I've added the description to the subject of an email if sharing to email app or any app that uses the subject field
Fixed android only condition + removed a tab typo :)
kusma
kusma approved these changes Mar 10, 2019
View reviewed changes
Copy link
Contributor

@kusma kusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@kusma kusma merged commit f4a1db2 into fuse-open:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusma kusma kusma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewEQ @kusma @ckarmy