Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target nodejs v8 (BREAKING) #22

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

target nodejs v8 (BREAKING) #22

wants to merge 2 commits into from

Conversation

mortend
Copy link
Member

@mortend mortend commented Jan 15, 2023

This adds support for async/await. Prior to this patch, transpiled code
using these features had references to "regeneratorRuntime", which gives
errors at runtime when used in Fuse apps since "regeneratorRuntime" is
not defined there.

Node.js v8 uses V8 v5.8, which is older than the version(s) we're
currently using in Fuse apps, so it's fairly safe to assume that all
JavaScript features used by transpiled code are supported in Fuse.

@mortend mortend force-pushed the async branch 3 times, most recently from 96e4f82 to 74b2c09 Compare January 15, 2023 19:31
@mortend mortend changed the title target nodejs v10 (BREAKING) target nodejs v8 (BREAKING) Jan 16, 2023
@mortend
Copy link
Member Author

mortend commented Jan 16, 2023

Don't merge yet.

Currently getting a runtime error when used in a Fuse app:

01-16 12:00:22.171 12796 27709 E fuse-contacts2: Error: TypeError: Class constructor ContactsExample cannot be invoked without 'new': Uncaught TypeError: Class constructor ContactsExample cannot be invoked without 'new'

@mortend mortend marked this pull request as draft January 16, 2023 05:05
This adds support for async/await. Prior to this patch, transpiled code
using these features had references to "regeneratorRuntime", which gives
errors at runtime when used in Fuse apps since "regeneratorRuntime" is
not defined there.

Node.js v8 uses V8 v5.8, which is older than the version(s) we're
currently using in Fuse apps, so it's fairly safe to assume that all
JavaScript features used by transpiled code are supported in Fuse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant