Update youtube vids #298
Open
Update youtube vids #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For blogs with W3 webinar Videos that are not yet published, the video iframe is commented out for now. |
MaxLenormand
reviewed
Jan 2, 2025
|
|
||
| <ReactPlayer playsinline={true} className="video__player" playing={true} muted={true} controls height="100%" url="https://fused-magic.s3.us-west-2.amazonaws.com/workbench-walkthrough-videos/dl4eo2.mp4" width="100%" /> | ||
|
|
||
|
|
||
| {/* truncate */} |
There was a problem hiding this comment.
Left over from before?
Suggested change
| {/* truncate */} |
| <ReactPlayer | ||
| playsinline={true} | ||
| className="video__player" | ||
| playing={true} |
There was a problem hiding this comment.
Suggested change
| playing={true} | |
| playing={false} |
I would not have these playing, I find this quite distracting personally. We can show people where the video is so they can watch it if they want, but I don't think we should play it for them. Feels a bit too much dark pattern for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embed YouTube webinar videos on top of each blog