-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for solaris native libraries #61
Conversation
Add support for solaris native libraries
Sounds good. Look like we need to spin a new hawtjni release soon. Thanks for the patch! |
@chirino Which version of LevelDB will be provide in new release? Your modified version of LevelDB is totally outdated. |
Feel free to send in a PR that merges in the latest changes in leveldb. |
I can try to send an PR for merging the last chagnes in leveldb. Do you need us to provide the built libleveldb.a or libleveldbjni.so on solaris for the bundle in new release? |
Yes. I do the release build in parts. I release the non-platform specific jar first. Then I release each platform specific module. Finally I release the -all module which packages them all together. If you guys would release the solaris platforms, that would be grand! |
Tricky bit might be how to pull in from your maven repos. |
This is a problem. |
One more problem is the |
Another way we could work around this issue is you move the solaris bits into a separate build project with a different group id (one your org controls) and just publish the solaris artifacts under that. You could even create your own version of the -all jar which includes everything this project's -all has but also adds the solaris bits. |
Thanks. |
I thought about releasing it under our org. But we don't really want there to be 2 different pacakges for leveldbjni. We would prefer it under your project :) Is there a way that I can work with you to package the solaris bits under your release?? I think we have options: We can offer you access to Solaris system for x86 and sparc if you would like to build and release them. I think this is the best option. Thanks for help |
For us to put it under our org, it would need to be released by us but we don't really have those solaris boxes. So it's best if you guys release it. We could just aggregate it in a subsequent release in the -all jar. |
Solaris box is not a problem! I will also see if I can get a groupId and do a release for solaris bits |
I am adding support for native library build on solaris:
-- sunos32 on x86
-- sunos64 on amd64
-- sunos64 on sparcv9
I am not adding sparc32 lib, since 32-bit Solaris JNI is actually EOL, plus there is a bug for JNI code on sparc32.
Some questions to discuss:
I am not able to test it on the current SNAPSHOT version due to this issue I posted:
Build fails on Linux 64 #57
Could you help with this issue?
Please see:
Added architecture specific native library loading path hawtjni#19
With dependency version for hawtjni updated in the next release, the test cases should pass and
build should succeed.
How does this look?
maven's central repository also.
If you don't have solaris or sparc machines available, we can offer the built leveldb and jni native
libraries binaries.
But I am not clear how the releases work?
Thanks for help.
Please let me know any comments for this pull request.