Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LevelDBTest JUnit-based integration test (incl. suitable POM) #89

Closed
wants to merge 2 commits into from

Conversation

vorburger
Copy link
Contributor

No description provided.

@vorburger
Copy link
Contributor Author

@chirino can I do anything here (clean up?) to get you to merge this? Tx!

@chirino
Copy link
Member

chirino commented Feb 8, 2017

I don't fully get this change. Unit test exist in:

https://github.com/fusesource/leveldbjni/blob/master/leveldbjni/src/test/java/org/fusesource/leveldbjni/test/DBTest.java

And each platform build should be running those unit tests already.

@vorburger
Copy link
Contributor Author

@chirino Duh! I admit I .. simply hadn't noticed DBTest, sorry. Noted it now, understood how surefire is configured to ignore it in that project by default, and how the platform builds use <testSourceDirectory>${basedir}/../leveldbjni/src/test/java to run it...

Also figured that an mvn -Dtest=DBTest test run in that project allows to run it, which will come in handy to test #90 (that was my main reason for doing it).

Abandoned this!

@vorburger vorburger closed this Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants