Proposed heartbeat implementation #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configurable via System property "stompjms.heartbeat"
Configurable via system property stompjms.heartbeat
Conflicts: stompjms-client/src/main/java/org/fusesource/stomp/jms/StompChannel.java
Test provided to proove bug in ActiveMQ's STOMP implementation disabled Will always fail until fixed in ActiveMQ project.
themerius
added a commit
to themerius/stompjms
that referenced
this pull request
Jun 28, 2016
…tation See fusesource#18 Usage with -Dstompjms.heartbeat=X,Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request also includes #13 (now closed)
The proposed implementation implements the STOMP 1.2 spec(http://stomp.github.io/stomp-specification-1.2.html#Heart-beating), and is configurable via the system property:
It may be debated if this should be configurable via the ConnectionFactory (and in which form: as a string or separate values).
Also changed the ActiveMQ integration test to use annotations in order to disable the AMQ-4493 proof (#13).
The proposed implementation has been tested using a camel app as client to ActiveMQ 5.8.0, using stomp-jms.
Restarting broker and client works as a charm, and stopping the heart-beats in the client (via debugger) makes the broker discard the client.
BR. Jan-Helge