Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing method of calling cubit #64

Merged
merged 20 commits into from
Aug 24, 2021
Merged

Conversation

shimwell
Copy link
Member

Proposed changes

Removes the make faceted geometry script and replaces it with a cubit python api version

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member Author

I've got to the stage where I can check the automated Cubit h5m export from the paramak. These tests work locally but it would be nice to get them working in CI.

@GregVernon are we ok to make use of Cubit learn in the CI testing of the Paramak on this new fusion-energy org?

@GregVernon
Copy link

@shimwell -- Absolutely! A large part of the reason we created the Learn license was to support the open-source simulation community.

@shimwell
Copy link
Member Author

Thanks @GregVernon

Just for full transparency the commit number 84f55bc would add Cubit to the docker image used for testing. This Docker image is saved on GitHub Container Registry and then used by Circle CI for testing. This saves rebuilding the docker image every time and Circle Ci just downloads the most recent build. Once this PR merged into the main branch this will trigger a rebuild and upload the new docker image containing Cubit. This would also mean Cubit is within the Docker image that is accessible to anyone here https://github.com/fusion-energy/paramak/pkgs/container/paramak .

Do let me know if this is over using the license and I shall see if there is another way without having Cubit appear in the distributed Docker image

@GregVernon
Copy link

GregVernon commented Aug 12, 2021

Do let me know if this is over using the license and I shall see if there is another way without having Cubit appear in the distributed Docker image

Thanks for the transparency. That's an appropriate use of the Learn license.

@shimwell
Copy link
Member Author

shimwell commented Aug 12, 2021

Thanks Greg.

This PR just needs a release of the latest Cubit Svalinn Plugins over on the Svalinn/Cubit_plugin for it to work as it is based on a Debian 10.10 Docker image then I shall merge it in

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #64 (7ad70b5) into develop (1731663) will not change coverage.
The diff coverage is n/a.

❗ Current head 7ad70b5 differs from pull request most recent head 4fb7049. Consider uploading reports for the commit 4fb7049 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #64   +/-   ##
========================================
  Coverage    94.15%   94.15%           
========================================
  Files           76       76           
  Lines         5251     5251           
========================================
  Hits          4944     4944           
  Misses         307      307           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1731663...4fb7049. Read the comment docs.

@shimwell
Copy link
Member Author

Circle is using an older docker image without the updated license. I shall make another PR to fix that

@shimwell shimwell merged commit ca941de into develop Aug 24, 2021
@shimwell shimwell deleted the changing_method_of_calling_cubit branch August 24, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants