-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing method of calling cubit #64
Conversation
I've got to the stage where I can check the automated Cubit h5m export from the paramak. These tests work locally but it would be nice to get them working in CI. @GregVernon are we ok to make use of Cubit learn in the CI testing of the Paramak on this new fusion-energy org? |
@shimwell -- Absolutely! A large part of the reason we created the Learn license was to support the open-source simulation community. |
Thanks @GregVernon Just for full transparency the commit number 84f55bc would add Cubit to the docker image used for testing. This Docker image is saved on GitHub Container Registry and then used by Circle CI for testing. This saves rebuilding the docker image every time and Circle Ci just downloads the most recent build. Once this PR merged into the main branch this will trigger a rebuild and upload the new docker image containing Cubit. This would also mean Cubit is within the Docker image that is accessible to anyone here https://github.com/fusion-energy/paramak/pkgs/container/paramak . Do let me know if this is over using the license and I shall see if there is another way without having Cubit appear in the distributed Docker image |
Thanks for the transparency. That's an appropriate use of the Learn license. |
Thanks Greg. This PR just needs a release of the latest Cubit Svalinn Plugins over on the Svalinn/Cubit_plugin for it to work as it is based on a Debian 10.10 Docker image then I shall merge it in |
Codecov Report
@@ Coverage Diff @@
## develop #64 +/- ##
========================================
Coverage 94.15% 94.15%
========================================
Files 76 76
Lines 5251 5251
========================================
Hits 4944 4944
Misses 307 307 Continue to review full report at Codecov.
|
…energy/paramak into changing_method_of_calling_cubit
Circle is using an older docker image without the updated license. I shall make another PR to fix that |
Proposed changes
Removes the make faceted geometry script and replaces it with a cubit python api version
Types of changes
Checklist