This repository has been archived by the owner on May 17, 2019. It is now read-only.
Revert require.cache busting #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clearing require.cache causes `Module did not self-register` error from binary dependencies - original issue was isolated in jestjs/jest#6887 - workaround: `fusion test --env node && fusion test --env jsdom` - downsides: coverage for node and jsdom tests are not consolidated Next steps: - tell people to use the workaround - wait for upstream fix in Jest
KevinGrandon
approved these changes
Aug 24, 2018
Merged
|
Is any permanent fix in progress for this? Otherwise our project test coverage is constantly reported wrongly. |
Yes, this was fixed in a recent version of fusion-cli, and should exist in 1.10.2. Fix was here: 005516e |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module did not self-registererrors from binary dependencies, which themselves cannot be worked around.fusion test --env node && fusion test --env jsdominstead offusion testif you have server and browser tests running concurrentlyNext steps: