Switch from pin-project to pin-project-lite #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another small step towards reducing the size of bollard's dependency tree :-) `tokio` and `hyper` have both switched from `pin-project` crate to the lighter-weight `pin-project-lite`: tokio-rs/tokio#1778 hyperium/hyper#2566 This does the same for bollard. For the differences between the two crates, see: https://docs.rs/pin-project-lite/0.2.8/pin_project_lite/#pin-project-vs-pin-project-lite Note: The full advantage of this won't be seen until a new `hyperlocal` release exists that contains: softprops/hyperlocal#54 ...and bollard updates to that release, so that `pin-project` can be fully dropped from the dependency tree.
|
The appveyor CI run failed, but due to a transient networking issue: However I'm not able to retrigger due to not having permissions. Could someone do the honour? :-) |
|
That looks sensible, maybe in future this project will be quicker to compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small step towards reducing the size of bollard's dependency tree :-)
tokioandhyperhave both switched from thepin-projectcrate to the lighter-weightpin-project-lite:tokio-rs/tokio#1778
hyperium/hyper#2566
This does the same for bollard. For the differences between the two crates, see:
https://docs.rs/pin-project-lite/0.2.8/pin_project_lite/#pin-project-vs-pin-project-lite
Note: The full advantage of this won't be seen until a new
hyperlocalrelease exists that contains:softprops/hyperlocal#54
...and bollard updates to that release, so that
pin-projectcan be fully dropped from the dependency tree. However this doesn't make things any worse in the meantime, sincepin-project-liteis already in bollard's dependency tree via bothhyperandtokio.