Only enable the tokio features used by this crate
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted, please rebase and I'll merge. |
Tokio offers the following features: https://docs.rs/tokio/latest/tokio/#feature-flags This removes the following unused Tokio features from `dependencies`: - `fs`: Since it's only used by examples/tests/doctests: https://github.com/fussybeaver/bollard/search?q=%22tokio%3A%3Afs%22 - `rt` / `rt-multi-thread`: Since it's not used by bollard itself, and should be specified by end-users in their application. By activating `rt-multi-thread` by default, it means anyone not using the multi-thread runtime has to pay the dependency/compile time price for it regardless. And the following from `dev-dependencies`: - `time` / `net`: Since they are already specified in `dependencies`, and it's not necessary to duplicate them in `dev-dependencies` as Cargo will perform feature unification. - `rt`: Since `rt-multi-thread` includes `rt` already. - `io-std`: Since it's not used by any examples/tests and isn't even one of the official top-level features anyway: https://docs.rs/tokio/latest/tokio/#feature-flags Note: The full benefits of this change won't be realised until this `hyperlocal` change is picked up in the next `hyperlocal` release: softprops/hyperlocal#54
edmorley
force-pushed
the
tokio-features-cleanup
branch
from
a948b0c to
2adefd2
Compare
|
Thank you, rebased :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokio offers the following features:
https://docs.rs/tokio/latest/tokio/#feature-flags
This removes the following unused Tokio features from
dependencies:fs: Since it's only used by examples/tests/doctests (so doesn't need to be independencies):https://github.com/fussybeaver/bollard/search?q=%22tokio%3A%3Afs%22
rt/rt-multi-thread: Since it's not used by bollard itself, and should be specified by end-users in their application (see authoring libraries). By activatingrt-multi-threadby default, it means anyone not using the multi-thread runtime has to pay the dependency/compile time price for it regardless.And removes the following from
dev-dependencies:time/net: Since they are already specified independencies, and it's not necessary to duplicate them indev-dependenciesas Cargo will perform feature unification.rt: Sincert-multi-threadincludesrtalready.io-std: Since it's not used by any examples/tests and isn't even one of the official top-level features anyway:https://docs.rs/tokio/latest/tokio/#feature-flags
Note: The full dependency tree/compile time reduction benefits of this change won't be realised until this
hyperlocalchange is picked up in the nexthyperlocalrelease (which stopshyperlocalfrom pulling in too manytokiofeatures):softprops/hyperlocal#54