Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for Id field instead of id when deserializing stats #298

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

kierendavies
Copy link
Contributor

This is needed for compatibility with Podman. I didn't test with Docker - I'm leaving that to CI.

@kierendavies
Copy link
Contributor Author

Looks like Podman and Docker conflict, so I'll change the rename to an alias

@kierendavies kierendavies force-pushed the podman-rename-id-field branch from 7830e6f to a56d50a Compare March 17, 2023 18:17
@fussybeaver
Copy link
Owner

Are you using the podman compat API?

Might be worth reporting the discrepancy in the upstream bug tracker: https://github.com/containers/podman/issues

@kierendavies
Copy link
Contributor Author

Good point, thank you! Reported containers/podman#17869

@kierendavies kierendavies force-pushed the podman-rename-id-field branch from a56d50a to 397bfff Compare March 21, 2023 12:36
@fussybeaver fussybeaver force-pushed the podman-rename-id-field branch from 397bfff to 84f5c26 Compare March 21, 2023 16:21
@fussybeaver fussybeaver merged commit a2bf891 into fussybeaver:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants