Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: judge by scannedVia #1456

Merged
merged 1 commit into from
May 6, 2022

Conversation

Nikkely
Copy link
Contributor

@Nikkely Nikkely commented May 6, 2022

What did you implement:

Currently, we use '.ScanndeBy' in order to judge the result was scanned by trivy. But '.ScannedBy' may have been changed when the result was scanned by trivy indirectly. So I guess that we should use '.ScannedVia' to judge it is scanned by trivy.
refs: #1444

Type of change

  • Refactor (non-breaking change which fixes an issue)

How Has This Been Tested?

Run at local

Checklist:

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@Nikkely Nikkely self-assigned this May 6, 2022
@MaineK00n MaineK00n merged commit 2158fc6 into future-architect:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants