Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ms): always sets isPkgCvesDetactable to true #1492

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Jul 14, 2022

What did you implement:

When family is windows, always set isPkgCvesDetactable to true.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Jul 14, 2022
detector/detector.go Fixed Show fixed Hide fixed
detector/detector.go Fixed Show fixed Hide fixed
detector/detector.go Fixed Show fixed Hide fixed
@MaineK00n MaineK00n force-pushed the MaineK00n/check-kbid-len branch from 3ba2836 to 02078fc Compare July 19, 2022 03:31
@MaineK00n MaineK00n force-pushed the MaineK00n/check-kbid-len branch from 02078fc to 3595a51 Compare September 1, 2022 08:34
@MaineK00n MaineK00n changed the title fix(ms): check KBID length fix(ms): always sets isPkgCvesDetactable to true Sep 1, 2022
@MaineK00n MaineK00n marked this pull request as ready for review September 1, 2022 10:44
Copy link
Collaborator

@sadayuki-matsuno sadayuki-matsuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaineK00n MaineK00n merged commit 947fbbb into master Sep 7, 2022
@MaineK00n MaineK00n deleted the MaineK00n/check-kbid-len branch September 7, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants