fix(scanner): fix socket file name length of SSH ControlPath #1714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Fixes #1713
In this implementation, the length of strings such as servername, user name, port number, etc. is not constant and the scan fails when the controlpath becomes long.
vuls/scanner/executil.go
Line 216 in a23abf4
Therefore, by using hash of
%C
and hash of servername, the length of the socket filename is fixed to make this problem less likely to occur.%C
is a new token from OpenSSH 6.7.https://www.openssh.com/txt/release-6.7
Type of change
How Has This Been Tested?
before
after
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference