Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detect/redhat): detect unpatched vulnerabilities with oval, stop using gost #1907

Merged
merged 2 commits into from
May 10, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented May 3, 2024

What did you implement:

Fixes #1906

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

vuls scan json: https://github.com/future-architect/vuls/files/15201332/vagrant.json

before

$ vuls report
[May  8 02:20:32]  INFO [localhost] vuls-v0.25.2-build-20240508_021813_f3f6671
...
vagrant (redhat8.9)
===================
Total: 382 (Critical:5 High:105 Medium:249 Low:13 ?:10)
72/382 Fixed, 43 poc, 0 exploits, cisa: 0, uscert: 0, jpcert: 0 alerts
522 installed

+----------------+------+--------+-----+-----------+---------+--------------------------------+
|     CVE-ID     | CVSS | ATTACK | POC |   ALERT   |  FIXED  |            PACKAGES            |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2023-2163  | 10.0 |  AV:L  |     |           |   fixed | kernel, kernel-core,           |
|                |      |        |     |           |         | kernel-devel, kernel-headers,  |
|                |      |        |     |           |         | kernel-modules, kernel-tools,  |
|                |      |        |     |           |         | kernel-tools-libs,             |
|                |      |        |     |           |         | python3-perf                   |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2019-15505 |  9.8 |  AV:L  |     |           | unfixed | kernel                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2023-25775 |  9.8 |  AV:N  |     |           | unfixed | kernel                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2023-37920 |  9.8 |  AV:N  |     |           | unfixed | ca-certificates                |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2023-45871 |  9.8 |  AV:A  |     |           |   fixed | kernel, kernel-core,           |
|                |      |        |     |           |         | kernel-devel,                  |
|                |      |        |     |           |         | kernel-modules, kernel-tools,  |
|                |      |        |     |           |         | kernel-tools-libs,             |
|                |      |        |     |           |         | python3-perf                   |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
...

after

$ vuls report
[May  8 02:12:44]  INFO [localhost] vuls-v0.25.2-build-20240508_021057_d679160
...
vagrant (redhat8.9)
===================
Total: 410 (Critical:6 High:115 Medium:273 Low:14 ?:2)
71/410 Fixed, 65 poc, 0 exploits, cisa: 0, uscert: 0, jpcert: 0 alerts
522 installed

+----------------+------+--------+-----+-----------+---------+----------------------------------------+
|     CVE-ID     | CVSS | ATTACK | POC |   ALERT   |  FIXED  |                PACKAGES                |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+
| CVE-2023-2163  | 10.0 |  AV:L  |     |           |   fixed | kernel, kernel-core,                   |
|                |      |        |     |           |         | kernel-devel, kernel-headers,          |
|                |      |        |     |           |         | kernel-modules, kernel-tools,          |
|                |      |        |     |           |         | kernel-tools-libs,                     |
|                |      |        |     |           |         | python3-perf                           |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+
| CVE-2019-15505 |  9.8 |  AV:L  |     |           | unfixed | kernel, kernel-core,                   |
|                |      |        |     |           |         | kernel-devel, kernel-headers,          |
|                |      |        |     |           |         | kernel-modules, kernel-tools,          |
|                |      |        |     |           |         | kernel-tools-libs,                     |
|                |      |        |     |           |         | python3-perf                           |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+
| CVE-2020-20703 |  9.8 |  AV:L  | POC |           | unfixed | vim-common, vim-enhanced,              |
|                |      |        |     |           |         | vim-filesystem, vim-minimal            |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+
| CVE-2023-25775 |  9.8 |  AV:N  |     |           | unfixed | kernel, kernel-core,                   |
|                |      |        |     |           |         | kernel-devel, kernel-headers,          |
|                |      |        |     |           |         | kernel-modules, kernel-tools,          |
|                |      |        |     |           |         | kernel-tools-libs,                     |
|                |      |        |     |           |         | python3-perf                           |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+
| CVE-2023-37920 |  9.8 |  AV:N  |     |           | unfixed | ca-certificates                        |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+
| CVE-2023-45871 |  9.8 |  AV:A  |     |           |   fixed | kernel, kernel-core,                   |
|                |      |        |     |           |         | kernel-devel,                          |
|                |      |        |     |           |         | kernel-modules, kernel-tools,          |
|                |      |        |     |           |         | kernel-tools-libs,                     |
|                |      |        |     |           |         | python3-perf                           |
+----------------+------+--------+-----+-----------+---------+----------------------------------------+

...

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this May 3, 2024
@MaineK00n MaineK00n changed the title feat(detect/redhat): detect not fixed package in oval, stop using gost feat(detect/redhat): detect vulnerabilities in not fixed packages with oval, stop using gost May 3, 2024
@MaineK00n MaineK00n force-pushed the MaineK00n/redhat-only branch 5 times, most recently from 171a30c to d679160 Compare May 3, 2024 23:24
@MaineK00n MaineK00n changed the title feat(detect/redhat): detect vulnerabilities in not fixed packages with oval, stop using gost feat(detect/redhat): detect unpatched vulnerabilities with oval, stop using gost May 3, 2024
@MaineK00n MaineK00n force-pushed the MaineK00n/redhat-only branch 3 times, most recently from d00a405 to 08773a1 Compare May 9, 2024 02:14
@MaineK00n MaineK00n marked this pull request as ready for review May 9, 2024 02:14
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! Fabulous! And lots of thanks for your support in my review time!!

@shino shino merged commit ef2be3d into master May 10, 2024
7 checks passed
@shino shino deleted the MaineK00n/redhat-only branch May 10, 2024 08:32
@shino
Copy link
Collaborator

shino commented Jul 8, 2024

Just for memo: vulsio/goval-dictionary#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive redhat unpatched vulnerability
2 participants