Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oval/suse): skip comparing TDC package and non-TDC package #2025

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MaineK00n
Copy link
Collaborator

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

Fixes #2024

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

by unit test

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Sep 16, 2024
@wagde-orca
Copy link
Contributor

@MaineK00n any work you still need to do with this PR? or it is ready to review and merge?

oval/util.go Show resolved Hide resolved
@MaineK00n
Copy link
Collaborator Author

@MaineK00n any work you still need to do with this PR? or it is ready to review and merge?

#2025 (comment)

@MaineK00n MaineK00n marked this pull request as ready for review September 19, 2024 01:55
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment but it's not mandatory.
🎊

@wagde-orca
Copy link
Contributor

@MaineK00n when do you pan to merge it?

@MaineK00n MaineK00n merged commit 1a54673 into master Sep 24, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/suse-teradata branch September 24, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positives in SUSE 12 SP3 Teradata kernels
3 participants