Component generator #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gradle/libs.versions.toml
# Conflicts: # iosApp/iosApp/Views/Screen/FirstView.swift
…generator # Conflicts: # gradle/libs.versions.toml # gradle/wrapper/gradle-wrapper.properties
Co-authored-by: Matej Semančík <matej.semancik@gmail.com>
Add support for Kotlin 2.0.0 🚀🚀🚀
matejsemancik
requested changes
Jun 29, 2024
Comment on lines
15
to
18
|
|
||
| // setup for component processor | ||
| arg("viewModel", "app.futured.kmptemplate.util.arch.ViewModelComponent") | ||
| arg("viewModelExt", "app.futured.kmptemplate.util.ext.viewModel") |
There was a problem hiding this comment.
Does this configuration actually relate to Koin, or is it just a shortcut to configure KSP for different thing?
Comment on lines
8
to
15
| //internal class LoginComponent( | ||
| // componentContext: ComponentContext, | ||
| //) : ViewModelComponent<LoginViewModel>(componentContext), LoginScreen { | ||
| // override val viewModel: LoginViewModel by viewModel() | ||
| // override val viewState: StateFlow<LoginViewState> = viewModel.viewState | ||
| // override val actions: LoginScreen.Actions = viewModel | ||
| // override val suspendActions: LoginScreen.SuspendActions = viewModel | ||
| //} |
There was a problem hiding this comment.
We can probably delete entire file, or just add a comment why this is actually commented out. Might be confusing for user.
Comment on lines
+5
to
+7
| @Target(AnnotationTarget.CLASS) | ||
| @Retention(AnnotationRetention.SOURCE) | ||
| annotation class Component(val argType: KClass<*> = Unit::class) |
There was a problem hiding this comment.
Can we get any documentation? 🥺👉👈
Comment on lines
+14
to
+16
| iosX64() | ||
| iosArm64() | ||
| iosSimulatorArm64() |
There was a problem hiding this comment.
Please replace with iosTargets() like in rest of the project.
Suggested change
| iosX64() | |
| iosArm64() | |
| iosSimulatorArm64() | |
| iosTargets() |
Comment on lines
+18
to
+22
| sourceSets { | ||
| commonMain { | ||
| dependencies { } | ||
| } | ||
| } |
There was a problem hiding this comment.
This empty configuration block can be removed
Comment on lines
+3
to
+5
| plugins { | ||
| id(libs.plugins.kotlin.multiplatform.get().pluginId) | ||
| } |
There was a problem hiding this comment.
Does the processor need multiplatform plugin? I think you should be able to get it working using just jvm plugin?
| @@ -0,0 +1,57 @@ | |||
| package com.rudolfhladik.componentprocessor | |||
There was a problem hiding this comment.
Can you update package name?
|
|
||
| class ComponentProcessor( | ||
| private val codeGenerator: CodeGenerator, | ||
| private val logger: KSPLogger, |
There was a problem hiding this comment.
Logger is unused, wanna keep it in? (I'm literally doing Danger's work here, which reminds me there should be ktlint and danger plugins added in component-processor and component-annotations Gradle projects)
|
|
||
| @Target(AnnotationTarget.CLASS) | ||
| @Retention(AnnotationRetention.SOURCE) | ||
| annotation class NavigationComponent() |
There was a problem hiding this comment.
This annotation class is unused, pls remove
| import com.squareup.kotlinpoet.ksp.toTypeName | ||
| import com.squareup.kotlinpoet.ksp.writeTo | ||
|
|
||
| class ComponentPoetGenerator { // TODO cant access classes from other modules |
There was a problem hiding this comment.
I guess this is WIP version of generator using Kotlin Poet?
It appears to be unused, pls
- remove this class (we can add it later when finished)
- remove kotlin poet dependency
# Conflicts: # androidApp/build.gradle.kts # gradle/libs.versions.toml # shared/feature/build.gradle.kts # shared/feature/src/commonMain/kotlin/app/futured/kmptemplate/feature/navigation/signedin/tab/b/TabBDestinations.kt # shared/feature/src/commonMain/kotlin/app/futured/kmptemplate/feature/ui/first/FirstComponent.kt # shared/feature/src/commonMain/kotlin/app/futured/kmptemplate/feature/ui/first/FirstViewModel.kt # shared/resources/build.gradle.kts
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KSP Processor for generating components from
ScreenInterface