Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contented-preview): with ContentNavigation non-unique react key #553

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

fuxingloh
Copy link
Owner

What this PR does / why we need it:

As per title.

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for contented ready!

Name Link
🔨 Latest commit 148d1cc
🔍 Latest deploy log https://app.netlify.com/sites/contented/deploys/64d2cfb5e2b9f30008f08e3f
😎 Deploy Preview https://deploy-preview-553--contented.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #553 (148d1cc) into main (50c3cac) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files          10       10           
  Lines         420      420           
  Branches       71       73    +2     
=======================================
  Hits          357      357           
  Misses         63       63           
Files Changed Coverage Δ
...ages/contented-processor/src/ContentedProcessor.ts 86.41% <50.00%> (ø)

@fuxingloh fuxingloh marked this pull request as ready for review August 8, 2023 23:32
@fuxingloh fuxingloh merged commit 4160016 into main Aug 8, 2023
@fuxingloh fuxingloh deleted the fuxingloh/non-unique-key-id branch August 8, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant