Make list solve_order predictable #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using solve_order() on a list could cause randomization of list members in an unpredictable order (see fvutils#221). This was due to toposort using sets and unordering the dictionary passed to it. This now appends the toposorted list fields in the same order that the randset had originally. Add testcase passing multiple lists in an ordered randset.
|
Thanks, @alwilson! Looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using solve_order() on a list could cause randomization of list members in an unpredictable order (see #221). This was due to toposort using sets and unordering the dictionary passed to it. This now appends the toposorted list fields in the same order that the randset had originally.
Add testcase passing multiple lists in an ordered randset.