FvwmPager: New mode IsShared for DesktopConfiguration shared. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
force-pushed
the
js/pager-is-shared
branch
from
6ac2c63 to
21ca7fc
Compare
ThomasAdam
added
type:enhancement
Just keep track of the pointer, no need for all the string comparisons. This only changes how monitor_to_track and the current_monitor are stored, functionality should be the same.
Add two options, IsShared, and IsNotShared, to turn IsShared mode on and off. When IsShared mode is set, every desktop only shows a single monitor like when tracking a single monitor, but the monitor shown is the most recent monitor to visit this disk. This can work with mixed results in per-monitor mode, but is meant for shared mode. There is currently no blocks to ensure it works well with other modes, so millage may vary. This also includes multiple tweaks/fixes, to make the pager work with shared mode better.
ThomasAdam
force-pushed
the
js/pager-is-shared
branch
from
21ca7fc to
f204d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First this cleans up FvwmPager's handling of
DesktopConfiguration shared. It should now correctly show the location of all windows and monitors when using shared mode, along with limit what clicks do. Only clicks in a desktop that a monitor is currently occupied will move through the pages, of the monitor on that desk. To move different monitors between desksMonitorLabelsshould be used.Here is a screenshot of the normal mode and
IsSharedmode when usingDesktopConfiguration sharedshowing 4 desks in a 2x2 grid. Each desk is further split up into 2x2 pages.The pager on the left is what shared mode looks like in a regular pager. As you can see there is a lot of blank space for each desktop for the other monitor, and since only a single monitor can view the desktop at a time, the space won't be used. The pager on the right is using the shared mode, only showing a single monitor at a time. In this case the unused space is no longer shown and the
MonitorLabelscan be used to move monitors between the desks.Note, this is built on top of #1002, so needs to be merged after.