Locale translation file updates. #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
reviewed
Oct 3, 2024
ThomasAdam
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Hi @somiaj
All looks good, save for one small change to the po/fvwmpo.sh script.
somiaj
force-pushed
the
js/translation-updates
branch
3 times, most recently
from
fd07c93 to
63e56f7
Compare
Move the scripts to update and build the LC_MESSAGE localization files out of automake makefiles (these are not used in the build anyways, but must be manually ran by translators). The automake file now only installs/uninstalls the LC_MESSAGE files for each language. There is a new script, po/fvwmpo.sh, which can be used to update the main pot file, initialize, update, and build the language files for the strings that gettext translates. This does essentially the same thing the make targets use to. Move all the translations into a single fvwm3.pot file (which merges the FvwmScript.pot file into the fvwm3.pot file). The file has also been renamed from fvwm.pot to fvwm3.pot to allow it to be installed along size fvwm2. Last, this updates the template, and merges all translation files to be in line with the current template, and rebuilds all the .gmo files that get installed into the locale directory.
somiaj
force-pushed
the
js/translation-updates
branch
from
63e56f7 to
b5ae1f4
Compare
|
I also found that the build command for building the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the scripts to update and build the LC_MESSAGE localization files out of automake makefiles (these are not used in the build anyways, but must be manually ran by translators). The automake file now only installs/uninstalls the LC_MESSAGE files for each language.
There is a new script, po/fvwmpo.sh, which can be used to update the main pot file, initialize, update, and build the language files for the strings that gettext translates. This does essentially the same thing the make targets use to.
Move all the translations into a single fvwm3.pot file (which merges the FvwmScript.pot file into the fvwm3.pot file). The file has also been renamed from fvwm.pot to fvwm3.pot to allow it to be installed along size fvwm2.
Last, this updates the template, and merges all translation files to be in line with the current template, and rebuilds all the .gmo files that get installed into the locale directory.