Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maximize keepgrowing flag. #1085

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Add Maximize keepgrowing flag. #1085

merged 1 commit into from
Oct 26, 2024

Conversation

somiaj
Copy link
Collaborator

@somiaj somiaj commented Oct 26, 2024

Add new keepgrowing flag to the Maximize function, which when growing windows will allow the window to grow beyond any window it is currently touching. This can be used similar to Move shuffle to grow windows to the next closest window boundary if currently touching a window.

Windows with size hint increments don't always work the best with this since they may not grow into the full space, thus won't be touching the next window and cannot grow beyond them. Move shuffle the window to touch before growing could help with this, though is clunky.

@ThomasAdam ThomasAdam self-assigned this Oct 26, 2024
@ThomasAdam ThomasAdam added the type:enhancement Augmenting an existing feature label Oct 26, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Oct 26, 2024
Add new `keepgrowing` flag to the Maximize function, which when growing
windows will allow the window to grow beyond any window it is currently
touching. This can be used similar to `Move shuffle` to grow windows to
the next closest window boundary if currently touching a window.

Windows with size hint increments don't always work the best with this
since they may not grow into the full space, thus won't be touching the
next window and cannot grow beyond them. `Move shuffle` the window to
touch before growing could help with this, though is clunky.
@ThomasAdam ThomasAdam added the relates:placement Issue is in window placement code label Oct 26, 2024
@ThomasAdam ThomasAdam merged commit 1067a72 into main Oct 26, 2024
12 checks passed
@ThomasAdam ThomasAdam deleted the js/max-grow-next branch October 26, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates:placement Issue is in window placement code type:enhancement Augmenting an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants