Make xkbcommon required in meson. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure. But, I would argue that xkbcommon should now be a core dependency. Just for meson. Although that's already implied with xfixes being introduced. |
somiaj
force-pushed
the
js/install-doc
branch
from
fa02b49 to
7db9658
Compare
|
Re xkbcommon, wing were also need to change meson.build? |
|
Ahh I thought you already updated that. Shouldn't we also remove the fallback code as well (though I guess this will only affect meson). |
|
I'm not updating. Just pointing this out. I guess this is delegation by subterfuge. 🙂 I don't think we need to worry about fallback code. Just meson. |
somiaj
force-pushed
the
js/install-doc
branch
from
7db9658 to
86a5ab9
Compare
somiaj
changed the title
Make xkbcommon a required dependency in meson. Move xext output into the dependencies block (missed when it was made required). Update INSTALL.md with this change and include some missing dependencies.
somiaj
force-pushed
the
js/install-doc
branch
from
86a5ab9 to
563e83e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there were a few missing optional dependencies.