Ensure a window's monitor is defined when placing it. #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that the FvwmWindow monitor is NULL, that can cause a crash when broadcasting the window's configuration to packet modules by referencing a NULL pointer to send the monitor's ID. This now happens with StartsOnPage due to #1076 setting the monitor to NULL initially. This fix ensures that the monitor is always defined after processing any StartsOnScreen settings, by setting it to the current monitor if it is still NULL. Also ensuring the monitor is defined here simplifies some future checks that were doing the same thing by falling back to the current monitor if it was undefined. This fixes the crash reported in #1100.
somiaj
force-pushed
the
js/placement-ensure-monitor-is-defined
branch
from
5e03c90 to
d9584f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the FvwmWindow monitor is NULL, that can cause a crash when broadcasting the window's configuration to packet modules by referencing a NULL pointer to send the monitor's ID. This now happens with StartsOnPage due to #1076 setting the monitor to NULL initially.
This fix ensures that the monitor is always defined after processing any StartsOnScreen settings, by setting it to the current monitor if it is still NULL. Also ensuring the monitor is defined here simplifies some future checks that were doing the same thing by falling back to the current monitor if it was undefined.
This fixes the crash reported in #1100.