GetDeskNumber fix, cleanup, and drop support for negative desks. #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function GetDeskNumber would not properly wrap more than once. For instance the command `GotoDesk 3 0 0` should return a desk between the minimum desk 0 and the maximum desk 0, but instead this would move the desk `2` from the current desk, because the wrapping code would only ever occur once. In fixing the issue, this also cleans up the logic in the GetDeskNumber function by better handling all the if cases and use the modulus function to do the wrapping. Last, support for negative desks is dropped, since it is not part of the EWMH spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function GetDeskNumber would not properly wrap more than once. For instance the command
GotoDesk 3 0 0should return a desk between the minimum desk 0 and the maximum desk 0, but instead this would move the desk2from the current desk, because the wrapping code would only ever occur once.In fixing the issue, this also cleans up the logic in the GetDeskNumber function by better handling all the if cases and use the modulus function to do the wrapping.
Last, support for negative desks is dropped, since it is not part of the EWMH spec.