Add math expansion variables. #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
force-pushed
the
js/math-expansion
branch
2 times, most recently
from
609a777 to
271f797
Compare
ThomasAdam
force-pushed
the
js/math-expansion
branch
from
271f797 to
3e2cc69
Compare
ThomasAdam
force-pushed
the
js/math-expansion
branch
from
3e2cc69 to
d2501e5
Compare
somiaj
force-pushed
the
js/math-expansion
branch
from
d2501e5 to
0947c69
Compare
This adds new expansion variables $[math.+.<x>,<y>], $[math.-.<x>,<y>], $[math.*.<x>,<y>], $[math./.<x>,<y>], $[math.%.<x>,<y>], and $[math.^.<x>,<y>], which can be used to do basic integer mathematics on the integers <x> and <y>. The comma in <x>,<y> allows for using floats in the future. This also updates the default-config to use these expansion variables instead of a shell to do the mathematics in its size computation.
somiaj
force-pushed
the
js/math-expansion
branch
from
0947c69 to
dd08342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new expansion variables
$[math.+.<x>,<y>],$[math.-.<x>.<y>],$[math.*.<x>.<y>],$[math./.<x>,<y>],$[math.%.<x>,<y>], and$[math.^.<x>,<y>]which can be used to do basic integer mathematics on the integers<x>and<y>. The comma in<x>,<y>is to allow for a future possibility of using floats. This also updates the default-config to use these expansion variables instead of a shell to do the mathematics in its size computation.