forked from bazelbuild/bazel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Minor AspectFunction / PrerequisiteProducer cleanups.
* Deduplicates TargetAndConfiguration state. It's already stored in PrerequisiteProducer.State, which AspectFunction.State has access to. Storing a second copy in AspectFunction.InitialValues could cause future problems. * Deletes PrerequisiteProducer.State.resolveAspectDependenciesResult. There are no restarts between this step and merging Aspects so storing it is not useful. * Deletes the aspectConfiguration parameter from AspectFunction.createAliasAspect. It's always the same as the one belonging to the primary AspectKey. * Replaces an expensive String.format call with cheaper concatenation. PiperOrigin-RevId: 523174761 Change-Id: I829ff523724f744343e3b74fff96f3d27b57e9ca
- Loading branch information
Showing
3 changed files
with
40 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters